MRCI/modules/Tester/command.h
Maurice O'Neal 594e1d9812 Major bug fixes and a few minor changes
Fixed a bug that caused the host to not respond to any commands when a
module is present. CmdExecutor::loadMods() had a malformed 'for' loop
that caused the command executor to infinite loop.

Also re-formed the way the external command loaders (modules) are
constructed. Instead, the modules are also intialized at the same time
as the internal command loader.

The CmdExecutor::loadModFile() and CmdExecutor::unloadModFile()
functions now load and unload modules via the module name instead of the
path to the module main file. The documentation for ASYNC_ENABLE_MOD and
ASYNC_DISABLE_MOD updated to reflect this change.

Also part of the module contruction re-form, it fixed a bug that caused
the command loaders to operate in a thread different from the command
executor. CmdExecutor::loadMods() was refactored into
cmdExecutor::buildCmdLoaders(), added the internal command loader to it
and have it so this function gets called only when the command executor
successfully moves to it's own thread.

Fixed a bug that caused the session to crash only when a module is
present. It turns out the qobject_cast() function used in
CmdExecutor::loadModFile() only pulled the surface class
ModCommandLoader so any attempt to access the base class functions from
CommandLoader caused the session to crash so to fix this,
ModCommandLoader was merged into CommandLoader. The Command loader
documentation and test module were updated to reflect this change.

Fixed a bug that auto removed any modules that were installed when the
host is restarted. The issue was in TCPServer::syncModPath() that used
the modules's main file without a suffix when the file did indeed have
a suffix, causing the function to think the module no longer exists and
remove all of it's files from the host file system. The original intent
for this function was to keep the module database table in sync with
what was actually in the host file system. It was decided that this is
not necessary so the function was removed altogether.

Also changed up the way the module files are deleted. The TCPSever class
will now use the module name instead of the path to the module's main
library file and will use a single use ModDeleteTimer for each module
that was requested to be deleted instead of a single continuous timer
constantly checking for modules to delete.

The ls_cmds command will now list the commands in alphabetical order of
the command names and fixed a bug with the -find option that would
display nothing if an exact match to any text in the table could not be
found.

Fixed a bug found in the deployed application that would segmentation
fault on startup due to certain library files being included in the
deployed installation directory. Updated the linux_build.sh script to
include only libsqlite, libQT5, libssl and libicu files. It will no
longer blindly copy all library files from the dev machine and then
remove files the setup script thinks the application might or might not
need.

Any module built on import rev1 will simply not work and no attempt will
be made to make it work so the host new minimum import rev is now rev2.

this update is mustly just bug fixes; nothing that would require any
client behaviour changes so just the host patch is bumped.

1.0.0 --> 1.0.1
2019-09-12 01:29:46 -04:00

171 lines
5.3 KiB
C++

#ifndef EXTERN_COMMAND_H
#define EXTERN_COMMAND_H
// This file is part of MRCI.
// MRCI is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
// MRCI is distributed in the hope that it will be useful,
// but WITHOUT ANY WARRANTY; without even the implied warranty of
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
// GNU General Public License for more details.
// You should have received a copy of the GNU General Public License
// along with MRCI under the LICENSE.md file. If not, see
// <http://www.gnu.org/licenses/>.
#define TXT_CODEC "UTF-16LE"
#define TXT_CODEC_BITS 16
#define MOD_LOADER_IID "MCRI.host.module"
#include <QObject>
#include <QTextCodec>
#include <QCoreApplication>
#include <QHash>
#include <QPluginLoader>
enum TypeID
{
GEN_FILE = 30,
TEXT = 31,
ERR = 32,
PRIV_TEXT = 33,
IDLE = 34,
HOST_CERT = 35,
FILE_INFO = 36,
PEER_INFO = 37,
MY_INFO = 38,
PEER_STAT = 39,
P2P_REQUEST = 40,
P2P_CLOSE = 41,
P2P_OPEN = 42,
BYTES = 43,
SESSION_ID = 44,
NEW_CMD = 45,
CMD_ID = 46,
BIG_TEXT = 47
};
enum ChannelMemberLevel
{
OWNER = 1,
ADMIN = 2,
OFFICER = 3,
REGULAR = 4,
PUBLIC = 5
};
class ExternCommand;
class SharedObjs : public QObject
{
Q_OBJECT
public:
const QHash<quint16, QString> *cmdNames;
const QList<QString> *chList;
const QList<QByteArray> *p2pAccepted;
const QList<QByteArray> *p2pPending;
const QList<quint16> *moreInputCmds;
const QList<quint16> *activeLoopCmds;
const QList<quint16> *pausedCmds;
const QString *sessionAddr;
const QString *userName;
const QString *groupName;
const QString *displayName;
const QString *appName;
const ushort *clientMajor;
const ushort *clientMinor;
const ushort *clientPatch;
const QByteArray *chIds;
const QByteArray *wrAbleChIds;
const QByteArray *sessionId;
const QByteArray *userId;
const bool *activeUpdate;
const bool *chOwnerOverride;
const uint *hostRank;
explicit SharedObjs(QObject *parent = nullptr);
};
class ExternCommand : public QObject
{
Q_OBJECT
protected:
void mainTxt(const QString &txt);
void errTxt(const QString &txt);
void privTxt(const QString &txt);
void bigTxt(const QString &txt);
public:
explicit ExternCommand(QObject *parent = nullptr) : QObject(parent) {}
virtual ~ExternCommand() {}
virtual void procBin(const SharedObjs *, const QByteArray &, uchar) {}
virtual void aboutToDelete() {}
virtual void term() {}
virtual bool handlesGenfile() {return false;}
virtual bool errState();
virtual QString shortText() {return "";}
virtual QString ioText() {return "";}
virtual QString longText() {return "";}
virtual QString libText() {return "";}
virtual QStringList internRequest() {return QStringList();}
QHash<QString, ExternCommand*> internCommands;
quint16 cmdId;
bool errSent;
bool inLoopMode;
bool inMoreInputMode;
signals:
void dataToClient(const QByteArray &data, uchar typeId = TEXT);
void castToPeers(const QByteArray &data, uchar typeId = TEXT);
void toPeer(const QByteArray &dst, const QByteArray &data, uchar typeId = TEXT);
void closeChByName(const QString &ch, const QString &sub);
void closeChById(quint64 id, uchar subId);
void openChByName(const QString &ch, const QString &sub);
void openChById(quint64 id, uchar subId);
void enableLoop(bool state);
void enableMoreInput(bool state);
void closeSession();
void cmdFinished();
void logout();
};
class CommandLoader : public QObject
{
Q_OBJECT
public:
explicit CommandLoader(QObject *parent = nullptr) : QObject(parent) {}
virtual ~CommandLoader() {}
virtual void modPath(const QString &) {}
virtual void aboutToDelete() {}
virtual bool hostRevOk(quint64) {return false;}
virtual QString lastError() {return "";}
virtual quint64 rev() {return 0;}
virtual QStringList pubCmdList() {return QStringList();}
virtual QStringList cmdList() {return QStringList();}
virtual QStringList rankExemptList() {return QStringList();}
virtual ExternCommand *cmdObj(const QString &) {return nullptr;}
};
QT_BEGIN_NAMESPACE
Q_DECLARE_INTERFACE(CommandLoader, MOD_LOADER_IID)
QT_END_NAMESPACE
#endif // EXTERN_COMMAND_H